Add support for localized image #183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this - sorry I've not looked it before now. I'll review this week and let you know! |
|
Sorry - I've not gotten around to this yet! |
|
It didn't initially compile - I think the Culture and LanguageCode properties got mixed up? The filename doesn't include the lproj extension that was shown in your screenshot. I guess that should be there? The API for adding the images doesn't allow you to specify the language code for a particular image. We currently allow images to be added like this: request.Images.Add(PassbookImage.Icon, System.IO.File.ReadAllBytes(Server.MapPath("~/Icons/icon.png")));We probably need a new way to add images, perhaps a method like: request.AddImage(PassbookImage.Icon, System.IO.File.ReadAllBytes(Server.MapPath("~/Icons/icon.png")));
request.AddImage(PassbookImage.Icon, "en", System.IO.File.ReadAllBytes(Server.MapPath("~/Icons/icon.png")));What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #182
need further test
Let me know what you think about it