Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rmkit] dependency on 'display' is too strict #834

Open
plan5 opened this issue Feb 22, 2024 · 1 comment · May be fixed by #860
Open

[rmkit] dependency on 'display' is too strict #834

plan5 opened this issue Feb 22, 2024 · 1 comment · May be fixed by #860
Labels
bug Something isn't working packages Add or improve packages of the repository
Milestone

Comments

@plan5
Copy link

plan5 commented Feb 22, 2024

Describe the issue
All rmkit packages depend on the 'display' package, even though some of them don't actually need it.
I specifically have genie and lamp in mind, which could be used without rm2fb if configured well.
On recent firmware versions without rm2fb support, this would be nice to have so these packages can be installed without risking a soft brick. Or if one doesn't want to use rm2fb for some reason.

To Reproduce
Steps to reproduce the behaviour:

  1. Install genie via opkg
  2. Observe 'display' package being installed as a dependency
  3. (If things go badly with a recent firmware) Soft-brick your device (well, you've been warned but anyhow)/

Expected behaviour
rmkit packages that do not need rm2fb do not pull it as a dependency.

Upstream issue
None.

Screenshots
None

Device/Package information (please complete the following information):

  • Device: reMarkable 2
  • OS version: 3.9.4.2018 rM Hacks v0.0.9
  • Package: rmkit
@plan5 plan5 added bug Something isn't working packages Add or improve packages of the repository labels Feb 22, 2024
@Eeems
Copy link
Member

Eeems commented Feb 22, 2024

Toltec doesn't support past 3.9, so we don't plan on making changes to make it easier to work on an unsupported version. We'd much rather work on the changes required to support a new version.

That said, genie and lamp both don't display to the screen themselves, so you are correct, they shouldn't depend upon display. Feel free to open a PR to make the installation dependencies more specific that the maintainer can merge.

@Eeems Eeems linked a pull request Jun 4, 2024 that will close this issue
@Eeems Eeems added this to the 3.x support milestone Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working packages Add or improve packages of the repository
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants