Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tolk imports translation tokens from gems, but not translations #25

Open
ressu opened this issue Jan 20, 2013 · 5 comments
Open

Tolk imports translation tokens from gems, but not translations #25

ressu opened this issue Jan 20, 2013 · 5 comments

Comments

@ressu
Copy link
Contributor

ressu commented Jan 20, 2013

Tolk setup imports all translation tokens which have translations. This means that all tokens that come pre-translated by other gems, like rails-i18n get imported to tolk. This leads to problems like mentioned in issue #18. While setup imports the tokens, it doesn't import the translations from those gems.

This can easily be worked around by importing the translations manually. But a real solution would be to import translations only included in the project itself. Since most of those translations will be translated within the gems itself it seems a bit pointless to import them to Tolk.

@thomasdarde
Copy link
Member

I think it would be a nice improvment, but I have no idea on how to include only the tokens of the project , have you got any trail ?

@ressu
Copy link
Contributor Author

ressu commented Jan 21, 2013

I poked and prodded within the internals of Rails, but I wasn't able to
find any logical place to get the information directly. I'm guessing that
the only way would be to take the I18n load_path, prune it from data
external to the Rails project and feed it to a new Instance of
I18n::Backend. Sounds a bit clunky, but as far as I can see, it is the only
way.

On Mon, Jan 21, 2013 at 9:45 AM, Thomas Darde notifications@github.comwrote:

I think it would be a nice improvment, but I have no idea on how to
include only the tokens of the project , have you got any trail ?


Reply to this email directly or view it on GitHubhttps://github.com//issues/25#issuecomment-12487393.

Sami Haahtinen
Bad Wolf Oy
+358443302775

@thomasdarde
Copy link
Member

These are good start points for digging. I don't have a lot of time at the moment, but as soon as I can I'll try to find a good way, maybe we can see with the guys involved with i18n.

On 21 janv. 2013, at 18:54, Sami Haahtinen notifications@github.com wrote:

I poked and prodded within the internals of Rails, but I wasn't able to
find any logical place to get the information directly. I'm guessing that
the only way would be to take the I18n load_path, prune it from data
external to the Rails project and feed it to a new Instance of
I18n::Backend. Sounds a bit clunky, but as far as I can see, it is the only
way.

On Mon, Jan 21, 2013 at 9:45 AM, Thomas Darde notifications@github.comwrote:

I think it would be a nice improvment, but I have no idea on how to
include only the tokens of the project , have you got any trail ?


Reply to this email directly or view it on GitHubhttps://github.com//issues/25#issuecomment-12487393.

Sami Haahtinen
Bad Wolf Oy
+358443302775

Reply to this email directly or view it on GitHub.

@ruurd
Copy link

ruurd commented Mar 2, 2013

Any progress on this?

@thomasdarde
Copy link
Member

Sorry , I have no time these days for Tolk, but would happily merge any related Code !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants