Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid module order #30

Closed
JakubOnderka opened this issue Mar 12, 2024 · 2 comments
Closed

Invalid module order #30

JakubOnderka opened this issue Mar 12, 2024 · 2 comments

Comments

@JakubOnderka
Copy link

Module order is incorrect for compression module. For example, if using ngx_http_sub_module, string is not replaced because it it tries to replace content when it is already compressed.

For inspiration you can check

https://github.com/google/ngx_brotli/blob/a71f9312c2deb28875acc7bacfdd5695a111aa53/filter/config#L70-L85

@tokers
Copy link
Owner

tokers commented Apr 22, 2024

@JakubOnderka Got it, thanks!

@tokers
Copy link
Owner

tokers commented Apr 22, 2024

@JakubOnderka The patch was merged and I'm going to close this issue now.

@tokers tokers closed this as completed Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants