Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0: Make sure Rename token group and Duplicate token group cannot share name with an existing token group #2778

Closed
six7 opened this issue May 20, 2024 · 0 comments · Fixed by #2785
Assignees
Labels
plugin v2 variables, UI, WTCG format, Bitbucket

Comments

@six7
Copy link
Collaborator

six7 commented May 20, 2024

Right now when you right click a token group and you click Duplicate or Rename, we allow users to enter an existing token group's name. This should be strictly forbidden as it will lead to unintended side-effects. Just like when you edit a token name you cannot enter an existing token group name, we should make it so that for renaming or duplicating groups this is not possible.

To reproduce:

  • Create a token with a name foo.bar and another token with a name otherfoo.bar
  • Right click the group foo and click Duplicate.
  • Enter otherfoo.

This should show a warning and disable the Submit input.

Same as for rename:
To reproduce:

  • Create a token with a name foo.bar and another token with a name otherfoo.bar
  • Right click the group foo and click Rename.
  • Enter otherfoo.

This should show a warning and disable the Submit input.

CleanShot.2024-05-20.at.14.34.15.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin v2 variables, UI, WTCG format, Bitbucket
Projects
Status: ✅ Done
2 participants