Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-blocking near-realtime indexing #217

Open
darkskygit opened this issue Feb 25, 2023 · 2 comments
Open

non-blocking near-realtime indexing #217

darkskygit opened this issue Feb 25, 2023 · 2 comments
Assignees
Labels
bug Something isn't working feat New feature or request mod:server Related to server

Comments

@darkskygit
Copy link
Member

At present, the index behavior is designed to be executed when the search interface is called, which will block the search interface in a large workspace.

We should trigger the index or add the content to the index queue when the doc is modified. When the search interface is called, we should always search for the indexed data.

Previously, the internal data of yrs could not be accessed safely across threads, which was improved in new version. We should adjust the design of the search function to optimize performance.

@darkskygit darkskygit added server:bug feat New feature or request labels Feb 25, 2023
@darkskygit darkskygit self-assigned this Feb 25, 2023
@doodlewind doodlewind added bug Something isn't working mod:server Related to server and removed server:bug labels Feb 27, 2023
@water-in-stone
Copy link

Does the issue persist as a bug? Furthermore, I aspire to contribute code to the development of OctoBase.

@darkskygit
Copy link
Member Author

Does the issue persist as a bug? Furthermore, I aspire to contribute code to the development of OctoBase.

Yes, the problem still exists! However we have recently rewritten the implementation to be compatible with yjs, it can be safely called by multiple threads, so we can transform the full-text index into a non-blocking implementation.

In addition, this issue is also related to another issue: #508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feat New feature or request mod:server Related to server
Projects
None yet
Development

No branches or pull requests

3 participants