Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CODEOWNERS more flexible #65

Open
caniszczyk opened this issue Jun 4, 2019 · 2 comments
Open

Make CODEOWNERS more flexible #65

caniszczyk opened this issue Jun 4, 2019 · 2 comments

Comments

@caniszczyk
Copy link
Member

At the moment, you can require a review for everything list in CODEOWNERS via a setting in GitHub. It would be great if you can annotate a listing in CODEOWNERS that the review is optional for certain folders...

"/build/logs/ @user #required=false"

@willnorris
Copy link
Member

willnorris commented Jul 12, 2019

As a separate request, but closely related so I'll include it here...

At Google, our internal code ownership system requires at least 1 reviewer, as well as either the author or reviewer of the commit being an owner of the code. As I understand it, if you enable "Require review from Code Owners", then it actually has to be the reviewer who is an owner. This becomes problematic for projects that don't have very many owners.

So the concrete feature request would be to modify "Require review from Code Owners" to allow this to be satisfied by the code author being an owner (not just the reviewer).

@jeffmcaffer
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants