Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No length restrictions on service name & namespace will break internal components. #380

Open
devsatishm opened this issue Jun 21, 2018 · 1 comment
Labels

Comments

@devsatishm
Copy link
Contributor

devsatishm commented Jun 21, 2018

Description

Currently, there are no restrictions on length for service name & namespace during service creation. We have many internal components (s3 buckets, cloudfront distributions, api paths etc.) that will rely on these two user supplied values. If the user attempts to create services with longer names, some of the internal workflows (bucket/cloudfront creation) might fail during deployment/provisioning time. We can enhance the user experience if we can either detect these during service creation or apply restrictions on the length of these values (we already have restrictions on characters that we can use for service name & namespace). Observed the issue during website creation but similar issues can be reproduced for other service types.

Steps to reproduce

  1. Login & create a service of type: website
  2. Provide longer values (30 characters for example) for service name & namespace.
  3. Service creation will be successful but the first deployment fails during cloudfront creation with message like this - "An error occurred (InvalidArgument) when calling the CreateDistributionWithTags operation: The parameter CallerReference is too big."

If Jazz admin enables dedicated S3 bucket per service, similar error can be reproduced during bucket creation (maximum length allowed for bucket names = 63 characters. Ref: https://docs.aws.amazon.com/AmazonS3/latest/dev/BucketRestrictions.html)

Expected behavior:

  • If UI is being used for service creation, user shouldn't be allowed to provide longer values for service name & namespace.
  • If API is being used for service creation, API should throw input invalidation error when user supplies longer values for service name & namespace.

Actual behavior:
Service gets created successfully but the first deployment fails with message similar to the above.

Reproduces how often:
Always

Additional notes
UI & underlying API should not allow user to use longer values for service names & namespace. Define a maximum limit for the length on these values.

Aha! Link: https://t-mobile1t-mobile.aha.io/features/JZ-24

@devsatishm devsatishm added the bug label Jun 21, 2018
@gokulpits
Copy link
Contributor

we just setup jazz locally with the latest code from the master.Here the length of the Namespace and the service name are limited to 20 characters.So please check with the latest code from master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants