Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore creates dublicates #91

Open
Solar-Simon opened this issue Jan 17, 2023 · 11 comments
Open

Restore creates dublicates #91

Solar-Simon opened this issue Jan 17, 2023 · 11 comments
Labels
enhancement New feature or request

Comments

@Solar-Simon
Copy link

Hello there, for some time I switched several times between two phones. Sms-ie is the best solution for me to quickly move my Sms and call logs.

After some time I realized Sms counter has exploded. Now I have several duplicate of my Sms.

So recovery of the backup is more a inclusion of the backup. Guess I always had to erase existing Messages first.

My expected behavior would be, when I restore a backup, I get exactly the data of the backup. And not a mix of existing data and backup.

Now that I now, it's easy to change my workflow. But how do I remove all that Duplicates?

@tmo1
Copy link
Owner

tmo1 commented Jan 17, 2023

The behavior you describe, as well as the solution you arrived at of wiping messages before restoring, is discussed in the README. The reason the app does not attempt to avoid message duplication is that it can be tricky to ascertain if two similar looking messages are identical, when some of the metadata is the same but some different.

I don't currently have a good way to get rid of duplicate messages in an existing collection of messages. It would not be too difficult to write a script to identify and remove duplicates, once the above problem has been addressed.

@tmo1
Copy link
Owner

tmo1 commented Jan 19, 2023

I'm going to leave this issue open, as a place for discussion of the feasibility and desirability of implementing some sort of deduplication, but I don't currently have any plans to implement anything.

@tmo1 tmo1 added the enhancement New feature or request label Jan 19, 2023
@maverick74
Copy link

If not a duplicate, this is, at least, related to #58 .

@tmo1 That SMS-DB system you talked about to avoid duplicates would be indeed very handy...

@tmo1
Copy link
Owner

tmo1 commented Feb 10, 2023

Noted. I'm not sure I plan to implement deduplication in SMS I/E, but I'll consider it.

@Emporea
Copy link

Emporea commented May 23, 2023

Ok so this happened to me too now.
Any suggestions on how to remove duplicates from the backup json file?

@tmo1
Copy link
Owner

tmo1 commented May 24, 2023

Not at present - sorry. If I do implement something, I'll try to remember to post it here.

@farfromrefug
Copy link

@tmo1 could you implement a wipe for call.logs ? Right now I end up with duplicates after backup/restore

@tmo1
Copy link
Owner

tmo1 commented Jul 23, 2023

could you implement a wipe for call.logs ?

Android has call log wiping built in.

@farfromrefug
Copy link

@tmo1 I see. It can be done programmatically as other apps do it. Would be nice to have it in the app. Maybe even as a prompt option when importing calls.

@tmo1
Copy link
Owner

tmo1 commented Jul 23, 2023

It can be done programmatically as other apps do it. Would be nice to have it in the app. Maybe even as a prompt option when importing calls.

I'm not sure I see the point in duplicating native Android functionality, but I'll consider it.

@farfromrefug
Copy link

@tmo1 It is all about user experience. like the fact that you dont propose to set the dedaur message app from the app.
it is like permissions. they can be set from app info but as app devs we ask them from our apps to have a better user experience.

tmo1 added a commit that referenced this issue Jul 25, 2023
tmo1 added a commit that referenced this issue Sep 15, 2023
Ask to become the default SMS app when importing or wiping messages.

Addresses: #124, #91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants