Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing Contacts Creating Duplicate Entries #68

Open
rshxyz opened this issue Nov 1, 2022 · 3 comments
Open

Importing Contacts Creating Duplicate Entries #68

rshxyz opened this issue Nov 1, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@rshxyz
Copy link

rshxyz commented Nov 1, 2022

Recently went through contacts and did some name changes, I then exported contacts using the app and imported contacts on another phone. Some contacts show up as duplicate and I think it's only signal messaging app contacts

To reproduce the problem
Contact must be a signal contact

  1. Have no contacts
  2. Add new contact with their signal phone number and a random name
  3. Go to signal messaging app, find the number, you can see their name is not updated, click on their profile and click on contact details
  4. Go back to the contacts app, you should now see phone number and the option of using signal (could take a bit of time but you need to wait til you see signal messaging option)
  5. export the contacts (you will only see 1 contact exported)
  6. delete the contact of the number or all if you want (obviously make sure you have a backup if you deleted all contacts)
  7. import contacts (you will see 2 contacted imported)
  8. you now have 2 contacts with the same number and name

I wasn't able to reproduce the problem of them having different names but i was able to at least reproduce the double entries so hopefully fixing that fixes the name problem

@tmo1
Copy link
Owner

tmo1 commented Nov 2, 2022

Thank you for reporting this, but I was unable to reproduce the problem (on a fresh emulator image). In step 4, I'm not sure where I'm supposed to see "the option of using signal." I waited a bit, saw nothing, and proceeded. In steps 7-8, I only see one contact.

In any event, this is probably related to #52. If you can upload the exported JSON file (you can and should redact all PII - it shouldn't be too difficult with the minimal file in question), I can take a look and try to figure out and possibly fix the problem.

@tmo1 tmo1 self-assigned this Nov 2, 2022
@tmo1 tmo1 added the bug Something isn't working label Nov 2, 2022
@rshxyz
Copy link
Author

rshxyz commented Nov 3, 2022

This is what i meant in step 4 you can see that now you can call or message someone from the contacts app

Screenshot

Here is me doing what I outlined above and the output it generated

contacts-redacted.txt

@tmo1
Copy link
Owner

tmo1 commented Nov 4, 2022

Thanks! I tried importing the redacted file you provided: the app reported 2 contacts imported (as expected), the contacts app showed only 1 contact added, but when I tried to edit that contact, Android asked which of 2 versions of the contact I wanted to edit. Is this what you're seeing, or are you getting something else?

For more accurate analysis, it would probably help to have a version of the file closer to the actual one, where like values are redacted to like ones and unlike ones to unlike ones, e.g., all instances of "rshxyz" to "John Doe", "Thomas More" to "Adam Smith", "123-456-7890" to "555-555-1234", and "987-654-2310" to "555-555-5678", etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants