Skip to content
This repository has been archived by the owner on Jun 2, 2024. It is now read-only.

code style consistency #26

Open
assemblie opened this issue Aug 28, 2018 · 1 comment
Open

code style consistency #26

assemblie opened this issue Aug 28, 2018 · 1 comment

Comments

@assemblie
Copy link

it could be very useful to implement coding style guide like PSR-2:
https://www.php-fig.org/psr/psr-2/ (https://akrabat.com/checking-your-code-for-psr-2/)

  • refactor docblocks so they are consistent

here is an example: https://github.com/assemblie/Filebase/tree/style-guide

its really lot of changes for now but we can implement it step by step or create specific style guide:
https://github.com/squizlabs/PHP_CodeSniffer/wiki/Coding-Standard-Tutorial

imo its best to stay with PSR-2 as its most used across PHP ecosystem:
https://symfony.com/doc/current/contributing/code/standards.html
https://laravel.com/docs/5.6/contributions#coding-style
http://auraphp.com/contributing/#standards
https://flowframework.readthedocs.io/en/stable/TheDefinitiveGuide/PartV/CodingGuideLines/PHP.html#general-considerations
etc.

@timothymarois
Copy link
Member

I like the idea. I try to stay within consistency. But I can see where the smaller things like brackets after or below the line could use some better alignments. Let's do it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants