Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag feed's link and atom:link point to the global ones #1042

Open
McSinyx opened this issue Aug 4, 2023 · 1 comment
Open

Tag feed's link and atom:link point to the global ones #1042

McSinyx opened this issue Aug 4, 2023 · 1 comment
Labels
bug Something isn't working rss

Comments

@McSinyx
Copy link
Contributor

McSinyx commented Aug 4, 2023

For example, /tag/recipe/feed.xml should have the canonical link of /tag/recipe and atom:link pointing to self.

@tlienart
Copy link
Owner

tlienart commented Aug 4, 2023

So what happens here is that the general RSS feed takes _rss/head.xml and _rss/item.xml to build the feed.

In the default _rss/head.xml there's:

(...)
    <link> {{website_url}} </link>
(...)
    <atom:link
      href="{{fd_rss_feed_url}}"
      rel="self"
      type="application/rss+xml" />

and this is used for the per-tag RSS as well unless a specific tag head is given.

In the per-tag level, if no custom head tag is provided, we should adjust the insertion of {{website_url}} and {{fd_rss_feed_url}} to have /tag/tagname attached to it.

I'll try to get a fix in soon.

@tlienart tlienart added bug Something isn't working rss labels Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rss
Projects
None yet
Development

No branches or pull requests

2 participants