Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined is not an object(evaluating react3.default.proptypes.string), does not work with latest react-native@0.49.1 #118

Open
yogendrakarekar opened this issue Oct 6, 2017 · 11 comments

Comments

@yogendrakarekar
Copy link

yogendrakarekar commented Oct 6, 2017

The library is not updated to suit with latest react-native@0.49.1

@nickdirienzo
Copy link

nickdirienzo commented Oct 27, 2017

@yogendrakarekar if you install from 2a4a957 (this is the tip of master as of this comment), it'll work.

@tlenclos do you plan on releasing a version bump to publish the fix in npm?

@yogendrakarekar
Copy link
Author

yogendrakarekar commented Oct 28, 2017 via email

@nickdirienzo
Copy link

@yogendrakarekar no I wasn't suggesting that. There's a fix already in master, so you can have your react-native-audio-streaming dependency point to the SHA (or #master). Then it should work for you.

I was wondering if the maintainer had plans to publish a new version on npm which includes that fix since it's been in the repository for a while now.

@dzmitrys-dev
Copy link

Please bump the npm version

@theeomm
Copy link

theeomm commented Nov 14, 2017

@nickdirienzo what's the right way to point it master. I am currently just doing npm i -S https://github.com/tlenclos/react-native-audio-streaming#master. Is there another way to do it?

@BuffMcBigHuge
Copy link

BuffMcBigHuge commented Nov 17, 2017

@theeomm in your package.json, try "react-native-audio-streaming": "git+https://github.com/tlenclos/react-native-audio-streaming.git"

@nickdirienzo
Copy link

@theeomm yes, what @BuffMcBigHuge said but replace react-native-autogrow-textinput with react-native-audio-streaming. Or you can do npm install tlenclos/react-native-audio-streaming. Hope this helps!

@BuffMcBigHuge
Copy link

BuffMcBigHuge commented Nov 17, 2017

@nickdirienzo Ah! Thanks for pointing that out! I was upgrading React to 0.49.5 and the autogrow package had the same issue!

@salisuabubakar
Copy link

Please ... am confuse how to install from #master. Can someone do step by step instruction. Thanks for your time.

@salisuabubakar
Copy link

Finally i was able to install but app crashes before launch. I think there is an issue using it with Wix React Native Navigation. Can someone help. Thanks

@Erenner
Copy link

Erenner commented Dec 5, 2019

import PropTypes from 'prop-types';
Player.propTypes = {
url: PropTypes.string.isRequired
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants