Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle string in URL parameters that pass through React Router #422

Open
ssciolla opened this issue Jun 14, 2023 · 2 comments · May be fixed by #451
Open

Handle string in URL parameters that pass through React Router #422

ssciolla opened this issue Jun 14, 2023 · 2 comments · May be fixed by #451
Assignees
Labels
back end Involves changes to the back end application (Django) bug Something isn't working Effort: 16 Effort estimated at two days front end Involves changes to the front end (React) application and/or UI
Projects

Comments

@ssciolla
Copy link
Contributor

ssciolla commented Jun 14, 2023

This is related to but a bit beyond #236.

Currently, if the user enters a string in the URL parameter for queue ID, the tool will throw an error in the backend, a Queue Connection will appear in the UI, and NaN will appear in the breadcrumbs. This likely also affects manage URLs, so the solution should be reusable if possible.

After checking with the service owner, here are the suggested/desired changes:

  • Change the breadcrumb text to display the incorrect string or integer value entered, not the NaN
  • Change the error message to Oops! It looks like you've entered an invalid queue ID <copy entered str value from URL>in the URL. Please make sure to enter the correct numeric queue ID. You can find the accurate queue ID in your 'Manage Queue' list for reference.
  • Sample changes apply to the manage URLs
@ssciolla ssciolla added bug Something isn't working front end Involves changes to the front end (React) application and/or UI back end Involves changes to the back end application (Django) Effort: 16 Effort estimated at two days labels Jun 14, 2023
@ssciolla ssciolla added this to To Do in 1.9.0 Jun 14, 2023
@ssciolla
Copy link
Contributor Author

We should also look at whether this can be enforced more cleanly in the backend.

@jonespm jonespm removed this from To Do in 1.9.0 Aug 15, 2023
@jonespm jonespm added this to To Do in 1.10.0 via automation Aug 15, 2023
@Nyu10
Copy link

Nyu10 commented Nov 8, 2023

I would like to tackle this issue

@lhuang408 lhuang408 linked a pull request Dec 1, 2023 that will close this issue
@zqian zqian self-assigned this May 20, 2024
@zqian zqian moved this from To Do to In Progress in 1.10.0 May 20, 2024
@zqian zqian moved this from In Progress to To Do in 1.10.0 May 20, 2024
@zqian zqian moved this from To Do to In Progress in 1.10.0 May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back end Involves changes to the back end application (Django) bug Something isn't working Effort: 16 Effort estimated at two days front end Involves changes to the front end (React) application and/or UI
Projects
1.10.0
  
In Progress
Development

Successfully merging a pull request may close this issue.

3 participants