Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting logged out in another window should trigger redirect to login #213

Open
mfldavidson opened this issue Nov 4, 2020 · 1 comment · May be fixed by #401
Open

Getting logged out in another window should trigger redirect to login #213

mfldavidson opened this issue Nov 4, 2020 · 1 comment · May be fixed by #401
Assignees
Labels
bug Something isn't working Effort: 8 Effort estimated at full day front end Involves changes to the front end (React) application and/or UI good first issue Good for newcomers
Projects

Comments

@mfldavidson
Copy link
Contributor

If I am logged in to ROHQ in one window, and in another window I log out, nothing happens on the original page to tell me that I have been logged out. However, when I click on anything, I get errors that might not make sense to an end user. For example, if I get logged out while sitting on the /manage page, then click on a queue, it gives me Access Denied: You are not a host of this queue. If you believe you are seeing this message in error, contact the queue host(s). BUT it still shows me as "logged in" if you look in the upper right--i.e. it shows my uniqname and not a Login button.
image

The only way to get clarity on what is really going on and get the opportunity to login again is if I manually refresh the page.

Particularly bad if someone thinks they are in line and just waiting for the page to update to say it's their turn, or they are a host watching the queue waiting for someone to join, and they don't realize they've been logged out and thus the page isn't updating.

Ideal would be that getting logged out in another window causes the original window to redirect to Login, maybe with a red error message saying "You have been logged out. Please login again." or something.

@mfldavidson mfldavidson added bug Something isn't working front end Involves changes to the front end (React) application and/or UI labels Nov 4, 2020
@ssciolla ssciolla added the good first issue Good for newcomers label Nov 10, 2022
@tayheath
Copy link

Hello! I'm currently a student at the University of Michigan in the EECS 481 Software Engineering class and I'd love to try and tackle this issue. I've just recently joined the EECS-481-MyLA google group if you would like to contact me at all. I plan on making a pull request according to the contribution guidelines in a week or so when I complete my implementation of the bug fix!

@tayheath tayheath linked a pull request Apr 7, 2023 that will close this issue
@ssciolla ssciolla linked a pull request Apr 11, 2023 that will close this issue
@jonespm jonespm added this to To Do in 1.8.0 via automation Apr 18, 2023
@jonespm jonespm moved this from To Do to In Progress in 1.8.0 Apr 18, 2023
@ssciolla ssciolla added the Effort: 8 Effort estimated at full day label May 1, 2023
@ssciolla ssciolla removed this from In Progress in 1.8.0 May 15, 2023
@ssciolla ssciolla added this to To Do in 1.9.0 via automation May 15, 2023
@jonespm jonespm removed this from To Do in 1.9.0 Aug 15, 2023
@jonespm jonespm added this to To Do in 1.10.0 via automation Aug 15, 2023
@zqian zqian moved this from To Do to In Progress in 1.10.0 May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Effort: 8 Effort estimated at full day front end Involves changes to the front end (React) application and/or UI good first issue Good for newcomers
Projects
1.10.0
  
In Progress
Development

Successfully merging a pull request may close this issue.

5 participants