Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor inconsistency in incomplete messaging in single Add Non-UM Users workflow #391

Open
ssciolla opened this issue May 9, 2022 · 0 comments
Assignees
Labels
🐛 bug Something isn't working front end Involves changes to the React application or other client-related files

Comments

@ssciolla
Copy link
Contributor

ssciolla commented May 9, 2022

I noticed when reviewing #390 that the logic for showing the incomplete message with the name input in the single user workflow for Add Non UM Users is somewhat inconsistent. In handleSubmitClick in UserEnrollmentForm, the check is for (firstName === undefined && lastName === undefined), but in the nameInput block, the incomplete message is shown if either is undefined. This doesn't result in any major bugs, just some inconsistent messaging when you only enter a first name or last name. For instance, if you enter just a first name and hit submit, you only see validation errors, no incomplete message; but then if you leave something else incomplete and hit submit, then you do see the incomplete message.

@ssciolla ssciolla added the front end Involves changes to the React application or other client-related files label May 9, 2022
@ssciolla ssciolla self-assigned this May 9, 2022
@ssciolla ssciolla added the 🐛 bug Something isn't working label May 9, 2022
@ssciolla ssciolla assigned pushyamig and unassigned ssciolla Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working front end Involves changes to the React application or other client-related files
Projects
None yet
Development

No branches or pull requests

2 participants