Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement to usage of wait-port library or look for alternative #377

Open
pushyamig opened this issue Apr 4, 2022 · 0 comments
Open

improvement to usage of wait-port library or look for alternative #377

pushyamig opened this issue Apr 4, 2022 · 0 comments
Labels
back end Involves changes to the Express application or other server-related files dependencies Involves changes to NodeJS packages and versions

Comments

@pushyamig
Copy link
Contributor

Comments from @ssciolla

wait-port ends up in the production image, even though it's not necessary for OpenShift deployments. Perhaps this should be installed or fetched right before it's used in docker-compose-prod.yml. Maybe npx can be used here. https://docs.npmjs.com/cli/v8/commands/npx Then we could move wait-port to under devDependencies.

wait-port is getting a little old (no updates in almost 2 years). It is widely used but we may have to explore new options at some point.
@ssciolla ssciolla added back end Involves changes to the Express application or other server-related files dependencies Involves changes to NodeJS packages and versions labels Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
back end Involves changes to the Express application or other server-related files dependencies Involves changes to NodeJS packages and versions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pushyamig @ssciolla