Add one-second delay after redirect during OAuth reset (#371) #373
Conversation
ssciolla
added
🐛 bug
ssciolla
changed the title
ssciolla
changed the title
| if (errorBody.redirect === true) redirect('/') | ||
| if (errorBody.redirect === true) { | ||
| redirect('/') | ||
| await new Promise(resolve => setTimeout(resolve, 1000)) |
There was a problem hiding this comment.
Yeah.. This is a band-aid solution to me as well. To my understanding adding a time out should be avoided if you can.
There was a problem hiding this comment.
So this code only hit when OAuth token is revoked from canvas console?
There was a problem hiding this comment.
There are a few cases where it would be triggered actually. Anything that results in a redirect from InvalidTokenInterceptor.
There was a problem hiding this comment.
I can think about other solutions to this, just may be more code involved.
There was a problem hiding this comment.
I would prefer a more concrete solution than adding a timeout. But I am open for discussion, if that is not possible at all.
With that said, I spoke with @melindakraft on this she is fine if the change doesn't make it the release and worked on next phase of the project since this doesn't not disrupt user expectation.
There was a problem hiding this comment.
Okay. I'll close this PR for now. We can discuss more at a later time.
The PR aims to resolve #372.
It feels like a band-aid solution, but also low-risk. I also removed some redundant spacing in
AuthorizePromptI forgot about when implementingLayout(see #348).