Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-evaluate pattern of stateful wrappers with CustomTable #314

Open
ssciolla opened this issue Jan 31, 2022 · 0 comments
Open

Re-evaluate pattern of stateful wrappers with CustomTable #314

ssciolla opened this issue Jan 31, 2022 · 0 comments
Labels
enhancement New feature or request front end Involves changes to the React application or other client-related files

Comments

@ssciolla
Copy link
Contributor

I think some of these patterns could be further refactored and generalized. With a little tinkering, we could move the page state into CustomTable and then use that component directly (i.e. prepping columns and tableRows outside) rather than creating all these separate {specificName}Table components. Or, if we like the wrapper layer, we could add a generic to these wrappers and move the columns interface into CustomTable.

Originally posted by @ssciolla in #301 (comment)

@ssciolla ssciolla added enhancement New feature or request front end Involves changes to the React application or other client-related files labels Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request front end Involves changes to the React application or other client-related files
Projects
None yet
Development

No branches or pull requests

1 participant