Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement abstract InvitationService interface #295

Open
lsloan opened this issue Jan 7, 2022 · 0 comments
Open

implement abstract InvitationService interface #295

lsloan opened this issue Jan 7, 2022 · 0 comments

Comments

@lsloan
Copy link
Member

lsloan commented Jan 7, 2022

The CirrusInvitationService (renamed as suggested in the quote below) needs to be based on a new, abstract InvitationService interface. That way, invitation services other than Cirrus can have new services implemented for them, as needed.

Originally posted by @ssciolla in #247 (comment)

Extra credit: What if this was CirrusInvitationService? I guess I was thinking that we could have the class implement an InvitationService interface, and then have it dynamically load the correct module based on what provider is configured. That's probably too fancy at this point, but one of the big hurdles I see to this tool being useful to other institutions is that they either don't have a service like Cirrus or they have another one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants