Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp rounding error results in incorrect timestamp and overlapping lines #83

Closed
bob-lobster opened this issue Jan 3, 2024 · 2 comments
Assignees
Labels

Comments

@bob-lobster
Copy link

When converting from SRT to ASS, the timestamp is sometimes converted incorrectly and can result in overlapping disaply times.
Below are an SRT source file as well as the output from pysubs2 and SubtitleEdit which handled the scenario correctly.

In this case, pysubs2 converted 00:36:48,998 to 0:36:48.100 instead of 0:36:49.00

Original SRT

616
00:36:45,411 --> 00:36:48,915
Line1

617
00:36:48,998 --> 00:36:51,292
Line2

pysubs2

Dialogue: 0,0:36:45.41,0:36:48.92,Default,,0,0,0,,Line1
Dialogue: 0,0:36:48.100,0:36:51.29,Default,,0,0,0,,Line2

SubtitleEdit

Dialogue: 0,0:36:45.41,0:36:48.92,Default,,0,0,0,,Line1
Dialogue: 0,0:36:49.00,0:36:51.29,Default,,0,0,0,,Line2
@bob-lobster
Copy link
Author

I just tested and this is resolved with PR #77. It would be great if that could be merged for the next version.

@tkarabela tkarabela self-assigned this May 4, 2024
@tkarabela
Copy link
Owner

Fixed in version 1.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants