Protractor Timeouts

[coryrylan]

When running protractor test they will timeout on any component using the lazy load directive. Protractor watches the ngZone to know when pending xhr calls, timeouts and intervals are completed before running.
In the scroll-listener.ts the .sampleTime(100, scheduler) creates a interval that wont ever end during a protractor test. I found a way arount this by the adding the following code to the directive

ngAfterContentInit() {
    this.ngZone.runOutsideAngular(() => { // run outside angular
      this.scrollSubscription = getScrollListener(this._scrollTarget)
        .filter(() => this.isVisible())
        .take(1)
        .switchMap(() => this.loadImage(this.lazyImage))
        .do(() => this.setImage(this.lazyImage))
        .finally(() => this.setLoadedStyle())
        .subscribe(() => this.ngOnDestroy(),
        error => {
          this.setImage(this.errorImg || this.defaultImg);
          this.ngOnDestroy();
        });
    });
  }

According to this https://github.com/angular/protractor/issues/3349#issuecomment-232253059 Protractor watches the main ngZone so if we run the interval out of it protractor run successfully. I'm not sure how this would work with the protractor tests on this project but I can try to make a pull request when I get the chance.

[tjoskar]

Thanks for your feedback.
I can however not reproduce this. I'm using protractor in this project and it seams to work fine. But having said that, it may be a good idea to use ngZone.runOutsideAngular for performance improvement. But if we are using ngZone.runOutsideAngular, we need to use ChangeDetectorRef after we have lazy loaded the image, right? So angular knows that the view needs to rerender.

[tjoskar]

Since I can not reproduce this and it seams that you have a working solution. Do you want to submit a PR?

[coryrylan]

Sure, I'll see if I can get one in within the next week :)

[tjoskar]

I created a new version of the plugin. Can you try it out: npm install ng2-lazyload-image@2.2.3-0 to see if it fix the problem?

[coryrylan]

Sure! I'll try it out today

[tjoskar]

Closing this. Let me know if you still get timeouts.

[coryrylan]

@tjoskar just tested this today and it works, thank you for the fix! :)