Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The documentation is not very clear #427

Open
m98 opened this issue Dec 10, 2019 · 3 comments
Open

The documentation is not very clear #427

m98 opened this issue Dec 10, 2019 · 3 comments

Comments

@m98
Copy link

m98 commented Dec 10, 2019

I was going to use this module, but there are several problems in the documentation which I need to report:

  • The part which talks about SSR and SEO is not really clear, and it does not provide an example of a module import that uses this technique.

  • Other preset types are not included in the docs and you have to look for it on the library code (ssrPreset, intersectionObserverPreset)

Thank you

@tjoskar
Copy link
Owner

tjoskar commented Dec 25, 2019

Thank you for reporting this.

The part which talks about SSR and SEO is not really clear, and it does not provide an example of a module import that uses this technique.

I understand and I agree with you that it can be hard to understand how it works. I can try to clarify it. I will also accept PRs.

Other preset types are not included in the docs and you have to look for it on the library code (ssrPreset, intersectionObserverPreset)

intersectionObserverPreset is the default preset and it is not meant to be used in an external way, only internally. The same goes for ssrPreset, even though it might exist use cases when you want to use it externally (the only reason I export it was for backward compatibility but that was maybe a mistake).

@pouyababaie
Copy link

i believe the documentation is somehow weak.
i want to use the features like having an background image lazy load on my homepage component but you didn't say how to import the module to a generated component . or what i have an img html tag in my component and i want to load it immediately after loading the component
Thanks for putting time to this

@tjoskar
Copy link
Owner

tjoskar commented Aug 26, 2021

For reference about SEO: #526

@pouyababaie I'm not sure I understand what you are asking. If you want to lazy load a background image you should just need to add you image like this: <div [defaultImage]="defaultImage" [lazyLoad]="image"></div>, given that ng-lazyload-image have been added to your application. Can you create a new issue where you include some code that you are using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants