You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are some parts that we could need some cleanup.
Mark optional Input/Output as optional (?), along with: LazyLoadImageDirectiveProps.
Extract all class names to constants (ng-lazyloaded, ng-lazyloading, ng-failed-lazyloaded)
Create a higher order function for setLoadedStyle. Right now we are setting the class names in three different ways. Normalize it (see Cleanup #274 (comment)).
Remove platformId from LazyLoadImageDirective. This was added to detect if it was server rendered (7140a0f) but was implemented in a diffrent way later on.
There are some parts that we could need some cleanup.
ng-lazyloaded
,ng-lazyloading
,ng-failed-lazyloaded
)setLoadedStyle
. Right now we are setting the class names in three different ways. Normalize it (see Cleanup #274 (comment)).ng-lazyload-image/src/lazyload-image.ts
Line 109 in 7b22617
ng-lazyload-image/src/lazyload-image.ts
Line 116 in 7b22617
ng-lazyload-image/src/lazyload-image.ts
Line 128 in 7b22617
window
is undefined. We are checkingwindow
in three places:ng-lazyload-image/src/lazyload-image.directive.ts
Line 21 in 7b22617
ng-lazyload-image/src/lazyload-image.directive.ts
Line 75 in 7b22617
ng-lazyload-image/src/scroll-listener.ts
Line 20 in 7b22617
platformId
fromLazyLoadImageDirective
. This was added to detect if it was server rendered (7140a0f) but was implemented in a diffrent way later on.npx tslint -c tslint.json 'src/**/*.ts'
to get the errors"strict": true
intsconfig.json
and fix the errors"noImplicitAny": true
intsconfig.json
and fix the errorsPull requests is more than welcome :)
The text was updated successfully, but these errors were encountered: