Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll container's lazy loading is a bit off #241

Closed
sapierens opened this issue Dec 6, 2017 · 4 comments
Closed

Scroll container's lazy loading is a bit off #241

sapierens opened this issue Dec 6, 2017 · 4 comments
Assignees

Comments

@sapierens
Copy link
Collaborator

Currently images in scroll containers are lazy loaded based on window bounds. Which means that if a scroll container doesn't take up the whole screen, the image will be lazy loaded as soon as it enters window bounds, instead of the visible portion of scroll container.

Here's an illustrative image of what I mean:

I believe I have a solution to this, but it depends on #238 Rect implementation. So I will prepare a pull request when/if #238 gets merged.

@tjoskar
Copy link
Owner

tjoskar commented Dec 31, 2017

Hi @sapierens, are you still up for the task? :)

@sapierens
Copy link
Collaborator Author

I sure am, I'll try to prepare a pull request this week.

@sapierens
Copy link
Collaborator Author

Hey @tjoskar, I've submitted a PR for this - #258. Let me know what you think.

tjoskar pushed a commit that referenced this issue Jan 7, 2018
…tection

Improved isVisible function for images within scoll containers. #241
@tjoskar
Copy link
Owner

tjoskar commented Jan 7, 2018

Thanks @sapierens!

@tjoskar tjoskar closed this as completed Jan 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants