Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strictly enforce announcement group restrictions #1677

Closed
alanzhu0 opened this issue May 5, 2024 · 2 comments
Closed

Strictly enforce announcement group restrictions #1677

alanzhu0 opened this issue May 5, 2024 · 2 comments
Assignees
@aarushtools
Labels
area/announcements good first issue

Comments

@alanzhu0
Copy link
Member

alanzhu0 commented May 5, 2024

Announcements that are restricted to a certain group should only be visible and findable to members of that group. Currently, restricted announcements are hidden from the dashboard for people not in the group, but can still be found and viewed.

Need to change view announcement and search pages.
@aarushtools
Copy link
Contributor

Hi, can I have this issue?

@alanzhu0
Copy link
Member Author

alanzhu0 commented May 6, 2024

Yes!

aarushtools added a commit to aarushtools/ion that referenced this issue May 6, 2024
@aarushtools
fix: enforce announcement visibility restrictions (closes tjcsl#1677)
16092e0
aarushtools added a commit to aarushtools/ion that referenced this issue May 18, 2024
@aarushtools
fix(announcements): enforce announcement visibility restrictions (closes
25d4cc4 
 tjcsl#1677)
aarushtools added a commit to aarushtools/ion that referenced this issue May 18, 2024
@aarushtools
fix(announcements): enforce announcement visibility restrictions (closes
660d357 
 tjcsl#1677)
aarushtools added a commit to aarushtools/ion that referenced this issue May 19, 2024
@aarushtools
fix(announcements): restrict announcements visibility (closes tjcsl#1677
72ad5d5 
)
aarushtools added a commit to aarushtools/ion that referenced this issue May 19, 2024
@aarushtools
fix(announcements): restrict announcement visibility (closes tjcsl#1677)
69a1fe7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aarushtools aarushtools

Labels
area/announcements good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aarushtools @alanzhu0