Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgres: additional option -cC breaks global dumpall #322

Open
joergmschulz opened this issue Jan 6, 2024 · 0 comments
Open

postgres: additional option -cC breaks global dumpall #322

joergmschulz opened this issue Jan 6, 2024 · 0 comments
Labels

Comments

@joergmschulz
Copy link
Contributor

Summary

if I use the - DEFAULT_EXTRA_OPTS=-cC for postgres (which adds the dump and create commands for the saved databases), the saving of the global options pg_dumpall will not work.

 [01-postgres-db__ALL] Dumping PostgresSQL globals: with 'pg_dumpall -g' 
pg_dumpall: unrecognized option: C
pg_dumpall: hint: Try "pg_dumpall --help" for more information.
2024-01-06.22:08:13 [NOTICE] ** [01-postgres-db__ALL] Generating MD5 sum for 'pgsql_globals_postgres-db_20240106-220813.sql'
2024-01-06.22:08:13 [NOTICE] ** [01-postgres-db__ALL] Backup of 'pgsql_globals_postgres-db_20240106-220813.sql' created with the size of 0 bytes
2024-01-06.22:08:13 [NOTICE] ** [01-postgres-db__ALL] Sending Backup Statistics to Zabbix
Response from "zabbix-server:10051": "processed: 1; failed: 0; total: 1; seconds spent: 0.000150"
sent: 1; skipped: 0; total: 1

Steps to reproduce

add - DEFAULT_EXTRA_OPTS=-cC

What is the expected correct behavior?

there should be separate options for pg_dump and pg_dumpall for postgres. Or, just another option to include the dump/create commands, they could be interesting for mariadb and others as well.

additionally, you see the exit code of pg_dumpall isn't processed; the processed:1, failed: 0 isn't what happened....

@joergmschulz joergmschulz changed the title postgres: additional optio -cC breaks global dumpall postgres: additional option -cC breaks global dumpall Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant