Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using WebAssembly: wasm_exec.js #231

Open
jzabinski-dolios opened this issue Jan 7, 2022 · 1 comment
Open

Using WebAssembly: wasm_exec.js #231

jzabinski-dolios opened this issue Jan 7, 2022 · 1 comment

Comments

@jzabinski-dolios
Copy link

The documentation says:

Execution of the contents require a few JS helper functions which are called from WebAssembly. We have defined these in tinygo/targets/wasm_exec.js.

The file path is ambiguous: it could be referring to the file's location in the TinyGo repository, or to the location in the locally installed instance of TinyGo. It would be helpful to be explicit about the file's various locations. Maybe something like this:

Execution of the contents require a few JS helper functions which are called from WebAssembly. We have included the file in the local TinyGo installation. It can be found in [path/to/TinyGo]/targets/wasm_exec.js. It can also be found in the TinyGo repository at https://github.com/tinygo-org/tinygo/blob/release/targets/wasm_exec.js.
@aykevl
Copy link
Member

aykevl commented Jan 19, 2022

Fair point. Both files are the same for the same TinyGo version. So generally you should copy it from your local TinyGo installation but it doesn't matter much.

If you want, you can make a PR to make this clear. The source file is here: https://github.com/tinygo-org/tinygo-site/blob/release/content/docs/guides/webassembly.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants