Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py copies scapy-ssl_tls layers definitions to wrong folder when wheel is used #143

Open
rbo-ktw opened this issue Oct 8, 2018 · 4 comments

Comments

@rbo-ktw
Copy link

rbo-ktw commented Oct 8, 2018

Scapy-ssl_tls/setup.py copies its layers to:

C:\Python27\Lib\site-packages\python27\lib\site-packages\scapy\layers

when wheel package is installed.

get_layer_files_dst() method returns list of tuples (<folder>, [<files>]), where <folder> is an absolute path. According to distutils documentation it should copy these files where we expect, but it does not work because wheel module does not support absolute paths, and they end up being installed relative to site-packages (more info).

To solve this problem, there should be a relative (to sys.prefix) path returned.

@tintinweb
Copy link
Owner

Hi @rbo-ktw,

would you be able to provide a PR fixing the issue?

thanks,
tin

@rbo-ktw
Copy link
Author

rbo-ktw commented Oct 18, 2018

Hi @tintinweb

I have cloned the scapy-ssl_tls repo, created my private branch to provide a fix, but I can not push it:

remote: Permission to tintinweb/scapy-ssl_tls.git denied to rbo-ktw.
fatal: unable to access 'https://github.com/tintinweb/scapy-ssl_tls.git/': The requested URL returned error: 403

I am totally new to github, so maybe it is my fault. But I think it is due to lack of permission, which can be granted by project owner, isn't it?

@tintinweb
Copy link
Owner

tintinweb commented Oct 19, 2018

Hi @rbo-ktw,

fork to your github. checkout a new branch (git checkout -b fix/setup_wheel), commit changes, push to your github account and click the "create pull request" button that appears on your github repo page after pushing a new branch to your repo.

cheers,
tin

@rbo-ktw
Copy link
Author

rbo-ktw commented Oct 22, 2018

Hi @tintinweb

Thanks for your help. Here is PR: #147.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants