Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLSServerECDHParams incorrectly defined for TLS 1.1 #142

Open
alexmgr opened this issue Sep 12, 2018 · 0 comments
Open

TLSServerECDHParams incorrectly defined for TLS 1.1 #142

alexmgr opened this issue Sep 12, 2018 · 0 comments
Labels

Comments

@alexmgr
Copy link
Collaborator

alexmgr commented Sep 12, 2018

TLSServerECDHParams is defined as:

class TLSServerECDHParams(PacketNoPayload):
    name = "TLS EC Diffie-Hellman Server Params"
    fields_desc = [ByteEnumField("curve_type", TLSECCurveTypes.NAMED_CURVE, TLS_EC_CURVE_TYPES),
                   ShortEnumField("curve_name", TLSSupportedGroup.SECP256R1, TLS_SUPPORTED_GROUPS),
                   XFieldLenField("p_length", None, length_of="p", fmt="!B"),
                   StrLenField("p", '', length_from=lambda x:x.p_length),
                   ShortEnumField("scheme_type", TLSSignatureScheme.RSA_PKCS1_SHA256, TLS_SIGNATURE_SCHEMES),
                   XFieldLenField("sig_length", None, length_of="sig", fmt="!H"),
                   StrLenField("sig", '', length_from=lambda x:x.sig_length)]

which is correct for TLS 1.2 and above. In TLS1.1 and below, there is no scheme_type field. This causes the guess_payload_class heuristics of TLSServerKeyExchange to fail for TLS 1.1 traffic.

TLSServerKeyExchange needs to be made version tolerant.

@alexmgr alexmgr added the bug label Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant