Container image building and publishing #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #23 +/- ##
==========================================
- Coverage 97.10% 96.00% -1.11%
==========================================
Files 4 4
Lines 415 425 +10
==========================================
+ Hits 403 408 +5
- Misses 8 11 +3
- Partials 4 6 +2
Continue to review full report at Codecov.
|
displague
reviewed
Jan 11, 2022
jacobweinstock
force-pushed
the
container-image
branch
from
a76d900
to
5d7f71c
Compare
jacobweinstock
force-pushed
the
container-image
branch
from
5d7f71c
to
4e48894
Compare
jacobweinstock
force-pushed
the
container-image
branch
from
4e48894
to
ba0f923
Compare
Allows users to run ipxedust in a container. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
This uses goreleaser to build and push container images to quay.io for multiple architectures. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
jacobweinstock
force-pushed
the
container-image
branch
from
ba0f923
to
4632a43
Compare
| @@ -16,7 +16,7 @@ jobs: | |||
| - name: Install Go | |||
| uses: actions/setup-go@v2 | |||
| with: | |||
| go-version: "1.17" | |||
| go-version: "1.17.5" | |||
|
This is super old. Is it still relevant? |
It is definitely old. It needs a revisit code wise (merge main, possibly update versions, etc) and i'd still like to see it incorporated. |
|
no cycles for this. will re-open if/when i do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This enables building and publishing container images to quay.io/tinkerbell. GitHub actions and Goreleaser are set up to create and publish container images based on Git tags.
This could potentially be an example repo for how we could handle versioning. See proposal 0002.
CC: @displague
Why is this needed
Fixes: #22
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: