Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose a way to fully customize metadata source configuration #101

Open
detiber opened this issue Oct 4, 2021 · 1 comment
Open

Expose a way to fully customize metadata source configuration #101

detiber opened this issue Oct 4, 2021 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/discuss Indicates a PR or issue that requires discussion

Comments

@detiber
Copy link
Contributor

detiber commented Oct 4, 2021

Currently the metadata server is determined using the value of TINKERBELL_IP from the environment, but we should also likely allow configuration of the port, protocol or even the full URL:

Originally posted by @displague in #100 (comment)
@tstromberg tstromberg added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 5, 2021
@crayzeigh crayzeigh added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/important-longterm labels Mar 8, 2022
@chrisdoherty4 chrisdoherty4 added this to the v0.4 milestone Aug 30, 2022
@chrisdoherty4 chrisdoherty4 removed this from the v0.4 milestone Oct 25, 2022
@chrisdoherty4
Copy link
Member

tinkerbell/proposals#61 would make this more or less superfluous so its on hold until that proposal moves.

@chrisdoherty4 chrisdoherty4 added the triage/discuss Indicates a PR or issue that requires discussion label Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/discuss Indicates a PR or issue that requires discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tstromberg @splaspood @detiber @chrisdoherty4 @crayzeigh