Accountstatus LDAP always synced

[Nachtlichtermeer]

sudo -u www-data php /var/www/*/htdocs/tine20/setup.php --sync_accounts_from_ldap
without
--syncaccountstatus
tries to sync the account status.

(
    [accountLoginName] => 1
    [accountLastPasswordChange] =>
    [accountExpires] =>
    [accountPrimaryGroup] => 1
    [accountDisplayName] => 
    [accountLastName] => 1
    [accountFirstName] => 1
    [accountFullName] => 
    [accountEmailAddress] => 1
    [accountHomeDirectory] => 
    [accountLoginShell] => 
    [visibility] => 
    [accountStatus] => Closure Object
        (
            [parameter] => Array
                (
                    [$options] => <required>
                )

        )

)
a459b6 - setupuser - 2022-12-09T12:22:41+00:00 DEBUG (7): Tinebase_User::_checkAndUpdateCurrentUser::721 Diff found in field accountStatus current: disabled new: enabled
a459b6 - setupuser - 2022-12-09T12:22:41+00:00 DEBUG (7): Tinebase_User::_syncDataAndUpdateUser::648 Record needs an update

so if i deactivate an user in tine and sync with ldap this user is reactivated

[lab-at-nohl]

Hi, this is very unfortunate. I submitted a PR that may have caused this. In my testings everything was synced fine. However, I tested like changing ldap and check if these are synced back to Tine when user logs in.

Please see my changes in User.php. Especially the element accountStatus in the array. I guess I have overseen that the function is not executed but returned as such.

Could you change line 690 until 695 in file Tinebase/User.php like this and try again?

            'accountStatus' => call_user_func(function() use ($options) {
                if (isset($options['syncAccountStatus'])) {
                    return (bool) $options['syncAccountStatus'];
                }
                return null; 
            }), 

Can you try the Sync-Command with and without --syncaccountstatus after changing the file like above?

Thanks and sorry for the trouble.

[Nachtlichtermeer]

great, this works as expected!

without --syncaccountstatus old disabled users are disabled furthermore after LDAP-sync and with --syncaccountstatus they are reactivated

i leave the ticket open until bugfix is submited