Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove yarn.lock from top-level #1598

Closed
jeffsee55 opened this issue Nov 3, 2020 · 0 comments · Fixed by #1599
Closed

Remove yarn.lock from top-level #1598

jeffsee55 opened this issue Nov 3, 2020 · 0 comments · Fixed by #1599
Labels
bug Something isn't working

Comments

@jeffsee55
Copy link
Member

Description

While all of our documentation indicates users should use the npm cli, we have a yarn.lock at the top-level of the monorepo, indicating that at some point that hasn't been the case. We should remove the yarn.lock to avoid confusion.

NOTE: this doesn't mean you can't use yarn while consuming these packages from outside the monorepo, this ticket is specifically about contributing to the monorepo.

I haven't run into an issue (that I know of) though I think the type of issues you'd see here are very subtle and probably hard to diagnose. There's a pretty good read of the potential issues here.

@jeffsee55 jeffsee55 added the bug Something isn't working label Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant