Created Dropdown Options #897
Conversation
|
@pratikkabade is attempting to deploy a commit to the timlrx's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@timlrx any problem with pr? |
|
@pratikkabade the build failed. Could you run it through prettier and push the updated changes? |
|
I thought it failed because of permission youve set, sure I'll give it a try |
It's mostly prettier related. You should have initialized the husky git pre-commit hooks which will automatically run it through eslint and prettier, but since the code is already pushed, you can just run
|
|
@timlrx I've made |
|
@timlrx any problem with PR? |
|
@pratikkabade, the desktop version in good. The mobile version needs to be updated. I was thinking either to list it out but indent it like Dribble or making it an expandable dropdown like Figma. Any preference? |
| @@ -6,4 +6,12 @@ const headerNavLinks = [ | |||
| { href: '/about', title: 'About' }, | |||
| ] | |||
|
|
|||
| export const headerNavOptions = { | |||
There was a problem hiding this comment.
No need for an additional field. You can modify the original headerNavLink to something like this:
const headerNavLinks = [
{ href: '/', title: 'Home' },
{ href: '/blog', title: 'Blog' },
{ href: '/tags', title: 'Tags' },
{ title: 'Others': children: [
{ href: '/projects', title: 'Projects' },
{ href: '/about', title: 'About' },
]
]
There was a problem hiding this comment.
Got it I'll see if i could do that and will change
| @@ -37,6 +38,7 @@ const Header = () => { | |||
| {link.title} | |||
| </Link> | |||
| ))} | |||
| <NavOptions /> | |||
There was a problem hiding this comment.
You can move the rendering of all the headerNavLinks to NavOptions
EnhancementFixes #867
Implemented dropdown options in the navbar to allow users to hide additional options
Visuals