-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Supporting other OSs #11
Comments
Of course linux, great project! |
Seems like you'd be best off using a file system events library with adapters for all the OS's. It doesn't look like any of the Go libraries are complete, but fsnotify looks like it would cover just about everything other than OSX. |
Thanks for the feedback, I'll be working on a linux implementation the coming month. Your suggestion for using fsnotify confirms my findings as well, under the hood I did a small spike already: https://github.com/timeglass/glass/blob/master/daemon/watching/monitor_fsnotify.go I just have to test it to confirm it works as expected. |
Sweet. I'd like to try it out, but that led to a couple more feedback points / feature requests:
|
Windows 10! :-) |
+1 for windows support |
+1 for Linux support, very useful ! |
Thanks for the input guys, the +1s are helpful in finding focus for the next release - polls without polls, great! :), I created a separate issues for the test&contribution improvements: #19 |
@Saimount @ionutvmi @corn13read @ciryon |
Awesome! I'll give it a shot in linux |
on windows the files need to have the .exe extension
Why does the glass daemon need access from the firewall ? (sorry didn't get the chance to look into the code) Other then that it seems to work ok. UPDATE: my tests were done on win 7 x64 |
Thanks a lot for this, very appreciated! :-) I've done some limited testing on Windows 10 Pro Insider Preview (build 10130) and for me it seems to work great. All I had to do was to rename the binaries so they have .exe extensions. I'm using Cmder as my shell. |
Hi,It works well on linux. Thanks for this tool ;) |
@ionutvmi , thanks for trying it out! When running init it will attempt to retrieve time data from the default remote: timing data is stored in a separate "notes" branch and has to be retrieved explicitly. Additionally, whenever a timer is started it will do a version check to if you're running the latest, this is of course to speed up version rollouts. The latter probably triggered the firewall alert? Does this seems fair? Could the experience be improved on windows? |
I think I should be able to use it on a local git repo (without the need for a remote to be present). The version check is ok with me, the warning only shows only once anyway. |
Ah, I understand the problem now, thanks for reporting. I created a separate issue over here. I'll close this issue as cross platform support seemed to be working. |
File monitoring is implemented differently across platforms. The current implementation uses FSEvents (OSX), let me know what other platforms you would like to see implemented
The text was updated successfully, but these errors were encountered: