Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a better JSON serialization lib #74

Open
mesca opened this issue Aug 4, 2022 · 1 comment
Open

Use a better JSON serialization lib #74

mesca opened this issue Aug 4, 2022 · 1 comment
Assignees

Comments

@mesca
Copy link
Member

mesca commented Aug 4, 2022

Port metadata often contains "complex" objects (Datetimes, Numpy types, etc.) that are not easily serializable using the standard JSON module. The orjson library is a good candidate to tackle this issue, with the cost of introducing new dependencies. We should investigate further.

@mesca mesca self-assigned this Aug 4, 2022
@bertrandlalo
Copy link
Member

bertrandlalo commented Aug 5, 2022

Two problems in this lib for our usage

  • it only allows key of type string (but we sometimes use int) 'data': {1659675794020: {'A1': -0.01757812499999996, 'A2': -0.01757812499999996}....
  • it does not convert pd.Timestamp, only datetimes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants