Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply node wrongly requires method parameter #54

Open
jonathanjfshaw opened this issue Apr 15, 2020 · 0 comments
Open

Apply node wrongly requires method parameter #54

jonathanjfshaw opened this issue Apr 15, 2020 · 0 comments
Assignees

Comments

@jonathanjfshaw
Copy link
Contributor

AFAICS from the docs this should work:

    - id: my_apply
      module: timeflux.nodes.apply
      class: ApplyMethod
      params:
        func: abs

but it fails with Node 'my_apply': __init__() missing 1 required positional argument: 'method', because the signature is

    def __init__(self, method, apply_mode='universal',
                 axis=0, closed='right', func=None, **kwargs):

We should make method optional and raise an exception unless at least one of method and func are provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants