Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transformers breaking when using Instances #431

Open
MatthewMiddlehurst opened this issue Aug 21, 2020 · 1 comment
Open

Transformers breaking when using Instances #431

MatthewMiddlehurst opened this issue Aug 21, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@MatthewMiddlehurst
Copy link
Member

MatthewMiddlehurst commented Aug 21, 2020 •
edited

A number of transformers i have tested using transform(Instances)/transform(Instance) throw exceptions.
Ones currently broken include: ARMA, MatrixProfile, Differences, PowerSpectrum and SAX.

Aaron has tested the TimeSeriesInstances transform methods for these and verified that they work, but for backwards compatibility reasons both methods are required to work.

If both transform(Instances) and transform(TimeSeriesInstances) do the same thing it may just be easier to turn Instances into TimeSeriesInstances by default for an easy fix? May be a bit inefficient though.
@MatthewMiddlehurst MatthewMiddlehurst added the bug Something isn't working label Aug 21, 2020
@MatthewMiddlehurst MatthewMiddlehurst mentioned this issue Aug 21, 2020
Merged
@TonyBagnall
Copy link
Member

has this been fixed @MatthewMiddlehurst ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TonyBagnall @MatthewMiddlehurst