Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] towebp filter always returns new filename, even when conversion was unsuccessful #2875

Open
bitfactory-robin-martijn opened this issue Jan 5, 2024 · 1 comment
Labels
2.x Future bug Image(Helper) Issues related to the Image and ImageHelper classes

Comments

@bitfactory-robin-martijn
Copy link
Contributor

bitfactory-robin-martijn commented Jan 5, 2024

Expected Behavior

When using the towebp filter, the original filename should be returned if the file could not be converted.

Actual behavior

The filename is returned with towebp after it.

Steps to reproduce behavior

{{ file | towebp }}

If file is white-castle.tif, this still returns white-castle.webp.

Notes

What version of Timber are you using?

2.0.0

What version of WordPress are you using?

No response

What version of PHP are you using?

No response

How did you install Timber?

None

@Levdbas
Copy link
Member

Levdbas commented Jan 6, 2024

Hi @expedition-robin-martijn , thank you so much for your ticket and PRs you created! I will add this to the Image handling ticket and we will take a look at your pull requests.

@Levdbas Levdbas added 2.x Future Image(Helper) Issues related to the Image and ImageHelper classes and removed 2.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Future bug Image(Helper) Issues related to the Image and ImageHelper classes
Projects
None yet
Development

No branches or pull requests

2 participants