Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find a solution that prevents us from setting undefined properties on Timber objects #2704

Open
gchtr opened this issue Feb 3, 2023 · 0 comments
Open

Find a solution that prevents us from setting undefined properties on Timber objects #2704

gchtr opened this issue Feb 3, 2023 · 0 comments
Labels
2.x Future dev-feedback

Comments

@gchtr
Copy link
Member

gchtr commented Feb 3, 2023

In #2674, we fixed a problem with importing properties in Timber\Post::get_info() by using arrays instead of WP_Post objects. While this fixes PHPStan issues, it’s not really preventing us from setting undefined properties on Timber objects.

For the future, we should think about a solution for this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.x Future dev-feedback
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gchtr