Repo cleanup

[nlemoine]

Hey,

For readability and management sake, it would be great if the Timber repository would make a fall cleaning.

There's a lot issues/PRs, many of them are probably outdated. What do you think about using one those "stale bot" I see everywhere? I know they can sometimes be a bit "rude" when closing your legitimate issue without warning (we haven't teached them politeness yet) but I guess they are customizable enough to set a fair "stale" policy.

It would motivate us to bring more support to the raised ticket (at least me). Right now, I'm kinda lost in the issues ocean considering the amount of opened issues (this applies for PR too).

Branches would also need some cleanup too (IMHO).

Thoughts?

[Levdbas]

With hopefully a 2.0 somewhere this year (please)🤞, I think it would be a great idea to do some householding. I went through the oldest issues (#1647 was my latest) and those are the ones I found that probably can be closed because of several reasons.

If this is appreciated and acted upon, I am willing to go through the other issues as well. Really want to do my part in Timber. :)

@nlemoine @jarednova @gchtr

solved

• Relevanssi excerpt #1125
• term.get_posts not returning all posts in a loop #1366
• woocommerce.php $product = wc_get_product( $context['post'] -> ID ) cannot get correct result #1384 solution with @gchtr comment.
• Timber\Menu() returns default menu when using non-existent menu slug as parameter #1440
• Testing for template existence should be delegated to twig. #1475 probably in Rename init() to create_twig_loader(), and move cache filters to controller. #1492
• ACF repeater field not working when defined in code #1586
• Timber and Gutenberg: asking for future plans #1645
• Lazy loading of custom fields #1647

Questions, which might be closed

• Context with Multiple Shortcode Components #1185
• Is there a reasonable way to disable the twig part of timber? #1297
• Unofficial Timber Help & Support Facebook Group #1334
• Warning: call_user_func_array() expects parameter 1 to be a valid callback, no array or string given in C:\xampp\htdocs\marine\wordpress\wp-content\plugins\timber-library\lib\Twig.php on line 268 #1381 not related
• Co-Authors Plus guest author links are incorrect #1396 uses other plugin
• arguments from index.php on antoher sites ex: front-page #1424
• Suggestion: prefix generated filenames  #1427
• Code style and formatting in the documentation #1442
• pagination for 'post' archive.php bug - 404 error #1471
• ACF Image Crop + TimberImage #1501
• Incompatibility with TimberMenu #1529
• Warning: Wrong parameter count for class_alias() #1530 neeeds a higher PHP version as a fix.
• Posts from a category menu item not showing as expected in front end #1560 and probably stale
• Co-authors plus guest authors do not display #1582 uses other plugin which probably needs some custom code.
• How set timer cache ignore all get params from URL #1592
• Slow template locations #1612 weird use case.

Stale/outdated

• get_widgets misconception - documentation #1187
• Multisite tests have errors #1282 ?
• Twig cache fails to save on WP Engine #1311
• Feature Request: twig filter to resize & fit - no cropping #1332
• Feature Suggestion: TimberShortcode class #1336
• PostPreview should use mb_substr #1367
• Filter function working on WP not working on Timber #1390
• Dashboard Pages search returns Posts #1398 cannot reproduce
• Page previews always open a new tab #1400 cannot reproduce
• [question][feature-request] Get ACF repeater field with dot notation. #1416 outdated.
• TimberImage resize() filter broken for Bedrock users (and others?!) #1428 I think this was already fixed some time ago. Probably stale.
• custom post type pagination error 404 #1436
  Getting array instead of field value, triggered by Wordpress Importer. #1460
  \Timber\Post get_field method returns wrong post object #1462
  image resize not working on multisite #1469
  Warning: implode(): Invalid arguments passed in /timber-library/lib/MenuItem.php  #1477
  [Improvement] Building the context hierarchically #1536 superseded by Moving WP template file contents to a function #2569 ?
  Fatal Error: Uncaught Error: Class 'Timber\Timber' not found after update from 0.22.6 to 1.5.2 #1581
  Timber - WP Offload S3 plugin conflict #1591
  Menu slug error when Using Woocommerce #1595 never ran into this myself.
  PostPreview needs a way to filter content (based on semantic tagging) #1604
  WooCommere variable or grouped product display sample?  #1605 never heard back from reporter.
  Choose return value for get_host function #1611

[gchtr]

Oh yes, we’re pushing hard for a 2.0 release. And we’re getting there.

There's a lot issues/PRs, many of them are probably outdated. What do you think about using one those "stale bot" I see everywhere? I know they can sometimes be a bit "rude" when closing your legitimate issue without warning (we haven't teached them politeness yet) but I guess they are customizable enough to set a fair "stale" policy.

Yes, I think we’ve discussed using a stale bot before. We would have to be careful about making it not too aggressive.

From what I can see, there are bots that provide options to set labels that prevent issues from being closed automatically. I think that would help. Because there are quite a few issues that play into a bigger picture in different areas (CDN usage, image handling in general and others). Having these issues around could help us knowing which factors we’d have to consider. But then again, we could also create "overview" issues where we link closed issues.

So if one of you could help setting up a bot, then that would be great 👍.

I think we’re slowly moving away from trying to solve everything in Timber itself and let developers choose third-party libraries to solve certain problems. As Jared stated it nicely in a recent podcast-appearance, we’re trying to "get out of the way". When we focus more on the core of Timber, we don’t have to solve every issue or feature request. Instead, I guess we should be more strict and have a mindset where we say, if somebody really wanted to have a new feature and feels passionate about it, they could try to implement it themselves. And we could support them along the way. But it shouldn’t be our job to bear the brunt of the work.

So a cleanup is definitely needed. I see that I’m among the few people who has at least a bit of an overview. I will go through that list that you provided, @Levdbas. Thank you sooo much for that initial work 🙌. I appreciate it very much that you want to help here. It’s a very important part of this project. Taking the time to provide a helpful answer helps other find a solution too and will lead to fewer issues and questions in the future.

[nlemoine]

Huge thanks @Levdbas for this stale issues summary!

Funny story: I just read this morning a blog post about stale bots that argues... against them 😄

While they're pretty good arguments, I'm still convinced they do not apply to every situations and a stale bot might still be useful if set up according our needs. It won't hurt giving it a chance and can be removed anytime if it doesn't fit in the end.