Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance problems with large filewatch objects #6285

Open
nicks opened this issue Dec 13, 2023 · 0 comments
Open

performance problems with large filewatch objects #6285

nicks opened this issue Dec 13, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@nicks
Copy link
Member

nicks commented Dec 13, 2023

Repro Steps

  • Create a Tiltfile in a go project with lots of dependencies
  • Run go mod vendor

Current Behavior

tilt creates a very large FileWatch object in-memory

this slows down all operations, e.g.,

time tilt get filewatch -o yaml | tail -n 3
kind: List
metadata:
  resourceVersion: ""

real	0m0.729s
user	0m0.763s
sys	0m0.071s

even though all the data in the filewatch is never used

We should try to consolidate that data.

Additional context
Probably the simplest way to do this would be to add a new field, like "DirectoriesChanged", for consolidating lots of FilesChanged in a single directory.

@nicks nicks added the enhancement New feature or request label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant