Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tkey-device-signer, include binaries in repo #18

Open
mchack-work opened this issue Apr 17, 2024 · 0 comments · May be fixed by #19
Open

Use tkey-device-signer, include binaries in repo #18

mchack-work opened this issue Apr 17, 2024 · 0 comments · May be fixed by #19
Assignees

Comments

@mchack-work
Copy link
Member

mchack-work commented Apr 17, 2024

A TKey user can use tkey-verification to verify that their TKey hasn't been tampered with since provisioning. Currently this is done with the verisigner device app running during both provisioning and verification.

Goals:

  • Use the ordinary signer instead of a special verisigner binary so we don't have to maintain two device apps with almost the same code. The new tkey-device-signer v1.0.0 already contains the necessary firmware digest command, compatible with the verisigner app protocol.
  • Use the ordinary tkeysign Go package to communicate. It's now also compatible with the verisign device app.
  • Instead of having complicated build scripts that tries to build different tags of the device app used in tkey-verification from the same repo let's just put the binary files to embed directly in the repo.
  • Simplify the interface to the binaries.
  • As a side-effect, possibly support several vendor signing keys.

A minor security problem in verisigner made us want to use the ordinary tkey-device-signer in tkey-verification as well, since we don't want to maintain essentially the same code in two places. Note, though, that we might want to add some additional data to the key generation process.

@mchack-work mchack-work self-assigned this Apr 17, 2024
@mchack-work mchack-work changed the title Embed tkey-device-signer Use tkey-device-signer, include binaries in repo Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant