Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Monocypher verification of signature fails #2

Open
mchack-work opened this issue May 30, 2023 · 2 comments
Open

Bug: Monocypher verification of signature fails #2

mchack-work opened this issue May 30, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@mchack-work
Copy link
Member

mchack-work commented May 30, 2023

Verification of an ed25519 signature with the monocypher crypto_ed25519_check() seems to fail, unless I did something wrong.

Fails on both real hardware (red LED) and qemu.

Did we implement some memory function in tkey-libs wrong?

See branch test-verification for a test version of the signer:

https://github.com/tillitis/tkey-device-signer/tree/test-verification

@dehanj dehanj added the bug Something isn't working label Sep 11, 2023
@dehanj
Copy link
Member

dehanj commented Oct 4, 2023

@LoupVaillant Since you start to dig deeper using the TKey and since you are the author of Monocypher, I just wanted to give you an heads up that we have found this bug. It is most probably on our side, but maybe you have seen something similar before?

We haven't had the time to investigate it further, the plan is to put our attention to it in end of October.
Mostly didn't want you to run into it, if you plan to do verification on the TKey.

@LoupVaillant
Copy link

@dehanj, I’ll take a look, thanks for the notification. I was just wondering what to work on next, this looks like a good candidate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants