Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same command for getnameverison in both firmware and apps #13

Open
dehanj opened this issue Jan 19, 2024 · 2 comments
Open

Use the same command for getnameverison in both firmware and apps #13

dehanj opened this issue Jan 19, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@dehanj
Copy link
Member

dehanj commented Jan 19, 2024

To ensure that other client apps can get what app is running, and present an adequate error to the user,the getnameversion command needs to be the same regardless of device-app or firmware.

In firmware we have defined it as:
FW_CMD_NAME_VERSION (0x01)
FW_RSP_NAME_VERSION (0x02)

The protocol of the signer and all apps using it should be change to the above.

@dehanj dehanj added the enhancement New feature or request label Jan 19, 2024
@quite
Copy link
Contributor

quite commented May 6, 2024

Hm, feels like you had the chance to do this for the 1.0 release, but now it feels harder.

For my tkey-device-x25519 I used the same 0x01 and 0x02 like fw does, but alas...

@dehanj
Copy link
Member Author

dehanj commented May 7, 2024

You are right.
For 1.0 release we chose not to make breaking changes to the protocol to ease migration, i.e., you can use either version of the signer with either version of tkey-ssh-agent if you just load the app with tkey-runapp for example.

But in the long run it might be better to move to something else, like proto buffer or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants