Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address points have surplus properties #2024

Open
nvkelso opened this issue Dec 5, 2021 · 0 comments
Open

Address points have surplus properties #2024

nvkelso opened this issue Dec 5, 2021 · 0 comments
Labels

Comments

@nvkelso
Copy link
Member

nvkelso commented Dec 5, 2021

The only thing we really need for display is the address number, all the other properties just add fake database bulk to the payload.

  # address points
  - filter:
      "addr:housenumber": true
      geom_type: point
    extra_columns: [way]
    min_zoom: 17
    output:
      <<: *output_properties
      kind: address
      addr_housenumber: {col: 'addr:housenumber'}
      addr_street: {col: 'addr:street'}

With *output_properties being:

  - &output_properties
    area:
      call:
        func: util.safe_int
        args: [ { col: area } ]
    label_placement: {col: label_placement}
    min_zoom: {col: min_zoom}
    mz_label_placement: {col: mz_label_placement}
    name: {col: name}
    source: {col: source}

The property that cause the most bulk and should be removed:

  • addr_street

These other properties are sometimes populated but aren't useful and should be removed:

  • name
  • label_placement
  • kind_detail
  • landuse_kind
  • osm_relation

If the property appears in the buildings.yaml then it should be removed.

To make 2x sure it's no longer there we can strip propes in the queries.yaml, right after the way-based address points are generated:

WARNING: removing properties invokes https://github.com/tilezen/vector-datasource/blob/master/docs/SEMANTIC-VERSIONING.md so this is 2.0 territory.

Related: #2023.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant