Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Transition object being a promise sublcass #95

Open
stefanpenner opened this issue Apr 18, 2014 · 5 comments
Open

Consider Transition object being a promise sublcass #95

stefanpenner opened this issue Apr 18, 2014 · 5 comments

Comments

@stefanpenner
Copy link
Collaborator

The Transition object already mimics a thenable via then but lacks catch and finally etc, why not just make it a subclass

https://github.com/tildeio/router.js/blob/master/lib/router/transition.js

@jamesplease
Copy link
Contributor

Resolved in 83f33ba

@stefanpenner
Copy link
Collaborator Author

@jmeas no, that doesn't resolve it. That merely creates a promise like entity that decorates a rail promise, it does not create a subclass.

@jamesplease
Copy link
Contributor

Ah, gotcha 👍

@sandstrom
Copy link
Contributor

I'm doing some issues-gardening 🍀 🌷 and stumbled upon this. Is this still an issue? if not, perhaps it can be closed?

@rwjblue
Copy link
Collaborator

rwjblue commented Nov 5, 2016

Yes, it is still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants