Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling recognize should not affect the transition.from query params for subsequent transitions #337

Open
chbonser opened this issue Nov 27, 2023 · 0 comments

Comments

@chbonser
Copy link
Contributor

Calling router.recognize with a URL which matches the current route affects the transition.from.queryParams for subsequent transitions. I've created a PR with a failing test here.

Root cause seems related to the fact that toReadOnlyRouteInfo (source) closes over a WeakMap for ROUTE_INFOS which is then mutated on subsequent calls (including calls from router.recognize). I don't know the original intent here so I'm not sure the solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant