Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose RouterJS' TypeScript types publicly #250

Open
theseyi opened this issue Sep 10, 2018 · 2 comments
Open

Expose RouterJS' TypeScript types publicly #250

theseyi opened this issue Sep 10, 2018 · 2 comments

Comments

@theseyi
Copy link

theseyi commented Sep 10, 2018

The types for public interfaces should be exposed publicly to users who want to consume the types in their application, e.g. EmberJS users.

For example, the Ember Router class method didTransition has parameters that are passed in on invocation

export class ResolvedHandlerInfo extends HandlerInfo {

These types are not defined in the Ember JS typings and it's currently not easy to just install and import the router_js types
EDIT: #238 seems like it be related to the issues encountered with importing

@theseyi
Copy link
Author

theseyi commented Dec 6, 2018

Any interest in resolving this issue?

@Bnaya
Copy link

Bnaya commented Dec 15, 2018

yes! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants